Re: [PATCH] add 'svn:use-commit-times' property

Philip Martin wrote:
> masaru tsuchiyama <m.tmatma_at_gmail.com> writes:
>
>> + if (!fb->adding_file)
>> + {
>> + if (fb->use_commit_times && fb->changed_date)
>> + {
>> + SVN_ERR(svn_io_set_file_affected_time(fb->changed_date,
>> + fb->local_abspath,
>> + scratch_pool));
>> + }
>> + else if (fb->remove_use_commit_times)
>> + {
>> + SVN_ERR(svn_io_set_file_affected_time(apr_time_now(),
>> + fb->local_abspath,
>> + scratch_pool));
>> + }
>> + }
>> +
> The call to apr_time_now still looks wrong to me. If I understand the
> patch it causes the timestamp to be updated to the current time when
> svn:use-commit-times is removed. I don't know how this feature is
> supposed to be used but I would expect the timestamp to be unchanged
> when the property is removed. Is setting it to the current time
> useful behaviour?
I thought if a file with svn:use-commit-times was an input file for
build system,
it was convenient to force process the file by updating the timestamp.
But it may not need to update the timestamp.

Regards.

-- 
Masaru Tsuchiyama <m.tmatma_at_gmail.com>