On 08/08/2013 09:40 AM, Daniel Shahaf wrote:
> On Thu, Aug 08, 2013 at 09:26:09AM -0400, C. Michael Pilato wrote:
>> This tells the options parser that there are no command-line options
>> which follow, which would keep self.__repospath from being treated as an
>> option in the unlikely scenario that it begins with a hyphen.
>
> Right. 99% of the time whether the '--' is there doesn't matter, but I like
> putting it there always. You never know if a line of code won't get copied
> to another script that passes user input as the repos_path argument...
>
> I'm not suggesting we fix that throughout the entire script or the entire
> tools/ dir, but I am saying it would be nice for new code (i.e., code added
> in the patch or modified by it) to use '--' properly.
FWIW, I completely agree.
Received on 2013-08-08 15:48:21 CEST