[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1506576 - in /subversion/branches/fsfs-improvements/subversion/libsvn_fs_fs: fs.h fs_fs.c low_level.c temp_serializer.c transaction.c

From: Daniel Shahaf <danielsh_at_elego.de>
Date: Wed, 7 Aug 2013 10:43:39 +0300

Stefan Fuhrmann wrote on Sun, Aug 04, 2013 at 14:32:14 +0200:
> On Sun, Aug 4, 2013 at 9:12 AM, Daniel Shahaf <danielsh_at_elego.de> wrote:
>
> > stefan2_at_apache.org wrote on Wed, Jul 24, 2013 at 14:32:48 -0000:
> > > - const char *uniquifier;
> > > + intra-node uniqification content. */
> > > + struct
> > > + {
> > > + svn_fs_fs__id_part_t txn_id;
> > > + apr_uint64_t number;
> > > + } uniquifier;
> > > } representation_t;
> >
> > A later commit moved this to node_revision_t I think;
>
>
> Which later commit? This struct has never been (intentionally) moved.
>

Pilot error on my end I think. representation_t contains a 'uniquifier'
member, the pointer in line 471 is correct, and while I'm not sure about
the pointer in line 555 I believe the branch generates the same unparsed
uniquifiers as trunk; so all in all, nothing to see in this thread.

> -- Stefan^2.
>
>
> > shouldn't the
> > pointer in structure:471 be updated? (and I'm not sure if the statement
> > in structure:555 is still accurate)
> >
> > [ all line numbers are
> > ^/subversion/branches/fsfs-improvements/subversion/libsvn_fs_fs/structure_at_1510099]
> >
Received on 2013-08-07 09:44:22 CEST

This is an archived mail posted to the Subversion Dev mailing list.