[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1502964 - in /subversion/branches/fsfs-improvements/subversion/libsvn_fs_fs: fs_fs.c fs_fs.h lock.c pack.c util.c util.h

From: Daniel Shahaf <danielsh_at_elego.de>
Date: Wed, 7 Aug 2013 10:54:32 +0300

Stefan Fuhrmann wrote on Sun, Aug 04, 2013 at 23:17:54 +0200:
> But keep in mind that it took me 2 full weeks with a diff
> viewer copying difference after difference and grouping
> them into somewhat manageable chunks. I would expect
> that the review (incl. documenting the findings) will certainly
> take a similar amount of time - give or take fancy tool
> support.

Sure. As I said offlist, I think I might have been a tad too quick on
the Send button in that particular commit review --- i.e., asserted some
formal bug without considering whether it was in fact a problem and
merits a commit review calling it out. Sorry about that.

I do appreciate the improvements you're bringing in (and the fact that
you're trying to make them easier to review). I'll definitely dive back
into them in the coming week and try to familiarize myself with them.
(but in the meantime, I have a backlog of minor tasks which I might try
to clear)


Received on 2013-08-07 09:55:11 CEST

This is an archived mail posted to the Subversion Dev mailing list.