[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Log messages Re: svn commit: r1505729 - /subversion/branches/fsfs-improvements/subversion/libsvn_fs_fs/cache d_data.c

From: Daniel Shahaf <danielsh_at_elego.de>
Date: Sun, 4 Aug 2013 09:32:22 +0300

stefan2_at_apache.org wrote on Mon, Jul 22, 2013 at 16:49:25 -0000:
> Author: stefan2
> Date: Mon Jul 22 16:49:24 2013
> New Revision: 1505729
>
> URL: http://svn.apache.org/r1505729
> Log:
> On the fsfs-improvements branch: Rename a debug function.
>
> * subversion/libsvn_fs_fs/cached_data.c
> (dgb__log_access): rename to ...
> (dbg_log_access): ... this one

That's a classic example of a log message that leaves me "Huh?"-ed: it
says nothing more than the unidiff says. "Fix a typo in the function
name" would have been easier to understand.

This one is a trivial patch, but the point of "Describe the why, not the
what" applies to larger, less-trivial patches too. (And that's why
I made it)
Received on 2013-08-04 08:33:04 CEST

This is an archived mail posted to the Subversion Dev mailing list.