[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: fsfs-improvements branch complete

From: Philip Martin <philip_at_codematters.co.uk>
Date: Fri, 26 Jul 2013 15:38:44 +0100

Philip Martin <philip.martin_at_wandisco.com> writes:

> The branch uniquifiers aren't unique. I see the branch code writing
> different uniqifiers into the transaction files but _0 values appear in
> the revision file.

The code in svn_fs_fs__parse_representation doesn't seem to parse the
uniqifier properly:

(gdb) p string
$6 = 0x6c508e "_2"
(gdb) n
602 str = svn_cstring_tokenize(" ", &string);
(gdb)
603 if (str == NULL)
(gdb) p str
$7 = 0x6c508e "_2"
(gdb) n
607 rep->uniquifier.number = svn__base36toui64(NULL, str);
(gdb)
609 return SVN_NO_ERROR;
(gdb) p rep->uniquifier.number
$8 = 0

-- 
Philip
Received on 2013-07-26 16:39:44 CEST

This is an archived mail posted to the Subversion Dev mailing list.