Re: fsfs-improvements branch complete

On Fri, Jul 26, 2013 at 4:38 PM, Philip Martin <philip_at_codematters.co.uk>wrote:

> Philip Martin <philip.martin_at_wandisco.com> writes:
>
> > The branch uniquifiers aren't unique. I see the branch code writing
> > different uniqifiers into the transaction files but _0 values appear in
> > the revision file.
>
> The code in svn_fs_fs__parse_representation doesn't seem to parse the
> uniqifier properly:
>
> (gdb) p string
> $6 = 0x6c508e "_2"
> (gdb) n
> 602 str = svn_cstring_tokenize(" ", &string);
> (gdb)
> 603 if (str == NULL)
> (gdb) p str
> $7 = 0x6c508e "_2"
> (gdb) n
> 607 rep->uniquifier.number = svn__base36toui64(NULL, str);
> (gdb)
> 609 return SVN_NO_ERROR;
> (gdb) p rep->uniquifier.number
> $8 = 0
>

Thanks for spotting & fixing this!
The extra "_" was a recent addition to make output match /trunk.

-- Stefan^2.
Received on 2013-07-27 22:48:31 CEST