Re: fsfs-improvements branch complete

Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com> writes:

> After two weeks now, I finally completed the fsfs format 6 refactoring
> and improvement work on said branch. Please review. See also
> http://svn.haxx.se/dev/archive-2013-07/0385.shtml for the "split up
> fs_fs.c" part of it.
>
> If there are no objections, I will merge the code in the week of Aug 26th.
> During the review period, I will create two more branches:

I tried an experiment:

svnadmin create repo
svnmucc -mm -U file://`pwd`/repo put repo/format f put repo/format g

and I compared the results using trunk and the branch:

--- repo/db/revs/0/1 2013-07-26 15:07:42.261306730 +0100
+++ ../obj2/repo/db/revs/0/1 2013-07-26 15:08:01.785012296 +0100
@@ -4,14 +4,14 @@
 id: 0-1.0.r1/27
 type: file
 count: 0
-text: 1 0 14 2 1dcca23355272056f04fe8bf20edfce0 5d9474c0309b7ca09a182d888f73b37a8fe1362c 0-0/_2
+text: 1 0 14 2 1dcca23355272056f04fe8bf20edfce0 5d9474c0309b7ca09a182d888f73b37a8fe1362c 0-0/_0
 cpath: /f
 copyroot: 0 /
 
 id: 3-1.0.r1/184
 type: file
 count: 0
-text: 1 0 14 2 1dcca23355272056f04fe8bf20edfce0 5d9474c0309b7ca09a182d888f73b37a8fe1362c 0-0/_4
+text: 1 0 14 2 1dcca23355272056f04fe8bf20edfce0 5d9474c0309b7ca09a182d888f73b37a8fe1362c 0-0/_0
 cpath: /g
 copyroot: 0 /
 
The branch uniquifiers aren't unique. I see the branch code writing
different uniqifiers into the transaction files but _0 values appear in
the revision file.

-- 
Philip Martin | Subversion Committer
WANdisco | Non-Stop Data