Kidney blame's behaviour and edge cases
From: Daniel Shahaf <danielsh_at_elego.de>
Date: Thu, 13 Jun 2013 10:35:46 +0200
Definition: "kidney blame" == "blame -r N:M" with M<N. Currently it is
By and large, it should do exactly what 'blame -r M:N' does: walk the
Currently, the non-kidney blame checks one revision before the start ---
That behaviour cannot easily replicated for the -r N:M case since it's
So I suggest that blame -r N:M not try to find the "next change after
--- Another issue: what should 'blame -r 3:3' do? Currently it is allowed, and prints '-' for lines added before r3 and '3' for lines added in r3. I am not sure whether that is intentional / by design, or just an accident of the fact that whoever added the 'end_rev < start_rev' check should have used the broader condition 'end_rev <= start_rev' instead. (See r7438 <-> http://svn.apache.org/r847512). It seems to me it should ideally print '3' for every line, and the user should pass '-r 2:3' if he wants to distinguish "added in r3" from "added before r3". It would be easy to preserve the current behaviour, though, of printing '-' rather than '2' (where '2' here is the youngest change to that line, for lines added before r3). --- Cheers, DanielReceived on 2013-06-13 10:36:40 CEST |
This is an archived mail posted to the Subversion Dev mailing list.
This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.