[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Kidney blame's behaviour and edge cases

From: Bert Huijben <bert_at_qqmail.nl>
Date: Thu, 13 Jun 2013 12:29:35 +0200

> -----Original Message-----
> From: Daniel Shahaf [mailto:danielsh_at_elego.de]
> Sent: donderdag 13 juni 2013 10:36
> To: dev_at_subversion.apache.org
> Subject: Kidney blame's behaviour and edge cases
>

> Another issue: what should 'blame -r 3:3' do? Currently it is allowed,
> and prints '-' for lines added before r3 and '3' for lines added in r3.
> I am not sure whether that is intentional / by design, or just an
> accident of the fact that whoever added the 'end_rev < start_rev' check
> should have used the broader condition 'end_rev <= start_rev' instead.
> (See r7438 <-> http://svn.apache.org/r847512).
>
> It seems to me it should ideally print '3' for every line, and the user
> should pass '-r 2:3' if he wants to distinguish "added in r3" from
> "added before r3". It would be easy to preserve the current behaviour,
> though, of printing '-' rather than '2' (where '2' here is the youngest
> change to that line, for lines added before r3).

I would call this intentional, and would really like to keep this behavior.

I certainly don't call it a bug, as this is what makes it possible to know
that you need a larger range for blaming to obtain more info.

        Bert
Received on 2013-06-13 12:30:33 CEST

This is an archived mail posted to the Subversion Dev mailing list.