Re: svn commit: r1486463 - in /subversion/trunk/tools/server-side/svnpubsub: revprop-change-hook.py svnpubsub/client.py svnpubsub/server.py watcher.py

On Sun, May 26, 2013 at 08:06:47PM -0000, brane_at_apache.org wrote:
> +def main(repo, revision, author, propname, action):
> + else:
> + sys.stderr.write('Unknown revprop change action "%s"\n' % action)
> + return

Maybe sys.exit(1)? Otherwise the stderr output will likely go unnoticed
(libsvn_repos discards stderr when the exit code is zero).

> +if __name__ == "__main__":
> + if len(sys.argv) != 6:
> + sys.stderr.write("invalid args\n")
> + sys.exit(0)
> +

Same.
Received on 2013-05-26 23:22:56 CEST