Re: svn commit: r1486463 - in /subversion/trunk/tools/server-side/svnpubsub: revprop-change-hook.py svnpubsub/client.py svnpubsub/server.py watcher.py

On 26.05.2013 23:22, Daniel Shahaf wrote:
> On Sun, May 26, 2013 at 08:06:47PM -0000, brane_at_apache.org wrote:
>> +def main(repo, revision, author, propname, action):
>> + else:
>> + sys.stderr.write('Unknown revprop change action "%s"\n' % action)
>> + return
> Maybe sys.exit(1)? Otherwise the stderr output will likely go unnoticed
> (libsvn_repos discards stderr when the exit code is zero).
>
>> +if __name__ == "__main__":
>> + if len(sys.argv) != 6:
>> + sys.stderr.write("invalid args\n")
>> + sys.exit(0)
>> +
> Same.

I was wondering about that myself. I basically just copied the behaviour
of the commit-hook.

-- Brane

-- 
Branko Čibej
Director of Subversion | WANdisco | www.wandisco.com