[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1486463 - in /subversion/trunk/tools/server-side/svnpubsub: revprop-change-hook.py svnpubsub/client.py svnpubsub/server.py watcher.py

From: Daniel Shahaf <danielsh_at_apache.org>
Date: Mon, 27 May 2013 04:41:59 +0000

On Sun, May 26, 2013 at 09:22:48PM +0000, Daniel Shahaf wrote:
> On Sun, May 26, 2013 at 08:06:47PM -0000, brane_at_apache.org wrote:
> > +def main(repo, revision, author, propname, action):
> > + else:
> > + sys.stderr.write('Unknown revprop change action "%s"\n' % action)
> > + return
>
> Maybe sys.exit(1)? Otherwise the stderr output will likely go unnoticed
> (libsvn_repos discards stderr when the exit code is zero).

You haven't s/return/sys.exit(1)/ here. Do you disagree with that change?
Received on 2013-05-27 06:42:10 CEST

This is an archived mail posted to the Subversion Dev mailing list.