[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1470738 - in /subversion/trunk/subversion: include/svn_fs.h libsvn_fs/fs-loader.c libsvn_repos/dump.c

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Tue, 23 Apr 2013 17:54:01 +0100

stefan2_at_apache.org writes:

> Author: stefan2
> Date: Mon Apr 22 22:26:39 2013
> New Revision: 1470738
>
> URL: http://svn.apache.org/r1470738
> Log:
> Make svn_fs_verify accept a FS_CONFIG parameter similar to svn_fs_open()
> and svn_fs_create(). Use that in svn_repos_verify_fs2 to check FS with
> the same configuration parameters that were used open opening FS.
>
> Besides the mere symmetry aspect, this is essential use consistent cache
> settings during FS verification, particularly using the same, separate
> cache namespace.

> @@ -2466,7 +2480,9 @@ svn_fs_pack(const char *db_path,
> /**
> * Perform backend-specific data consistency and correctness validations
> * to the Subversion filesystem (mainly the meta-data) located in the
> - * directory @a path. Use @a scratch_pool for temporary allocations.
> + * directory @a path. Use the backend-specific configuration @a fs_config
> + * when opening the filesystem. @a NULL is valid for all backends.

I assume the NULL comment refers to fs_config? At the start of the log
you say it is essential to use consistent configs. Does using NULL
result in consistent configs?

> + * Use @a scratch_pool for temporary allocations.

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download
Received on 2013-04-23 19:05:28 CEST

This is an archived mail posted to the Subversion Dev mailing list.