[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1470936 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/stream.c libsvn_wc/adm_ops.c libsvn_wc/update_editor.c

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Tue, 23 Apr 2013 18:09:13 +0100

Ivan Zhakov <ivan_at_visualsvn.com> writes:

> On Tue, Apr 23, 2013 at 5:04 PM, <philip_at_apache.org> wrote:
>> Author: philip
>> Date: Tue Apr 23 13:04:42 2013
>> New Revision: 1470936
>>
>> URL: http://svn.apache.org/r1470936
>> Log:
>> Significantly reduce the number of open files during a typical update
>> over ra_serf by using lazy-opening streams to delay opening until the
>> HTTP response is received. This changes the new-in-1.8 lazy-open API.
>>
> [...]
>
>> --- subversion/trunk/subversion/libsvn_wc/update_editor.c (original)
>> +++ subversion/trunk/subversion/libsvn_wc/update_editor.c Tue Apr 23 13:04:42 2013
>> @@ -3525,6 +3525,46 @@ open_file(const char *path,
>> return SVN_NO_ERROR;
>> }
>>
> [...]
>
>> + tb = apr_palloc(handler_pool, sizeof(struct lazy_target_baton));
> apr_pcalloc() ? Otherwise it looks like needless premature optimization.

I prefer alloc with explicit initialisation unless we know zero is a
correct initialisation. Adding initialisation to zero makes it harder
to use a tool like valgrind to identify missing initialisations.

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download
Received on 2013-04-23 19:10:09 CEST

This is an archived mail posted to the Subversion Dev mailing list.