Re: svn commit: r1470738 - in /subversion/trunk/subversion: include/svn_fs.h libsvn_fs/fs-loader.c libsvn_repos/dump.c

On Tue, Apr 23, 2013 at 3:25 PM, Bert Huijben <bert_at_qqmail.nl> wrote:

>
>
> > -----Original Message-----
> > From: stefan2_at_apache.org [mailto:stefan2_at_apache.org]
> > Sent: dinsdag 23 april 2013 00:27
> > To: commits_at_subversion.apache.org
> > Subject: svn commit: r1470738 - in /subversion/trunk/subversion:
> > include/svn_fs.h libsvn_fs/fs-loader.c libsvn_repos/dump.c
> >
> > Author: stefan2
> > Date: Mon Apr 22 22:26:39 2013
> > New Revision: 1470738
> >
> > URL: http://svn.apache.org/r1470738
> >
> > +apr_hash_t *
> > +svn_fs_config(svn_fs_t *fs, apr_pool_t *pool)
> > +{
> > + return apr_hash_copy(pool, fs->config);
> > +}
> > +
>
> fs->config can be NULL (see your own documentation of this function). In
> this case it caused a segfault.
>

Oops - sorry! You are absolutely right.

> The JavaHL tests on our buildbots triggered this problem and I applied a
> simple fix in r1470908.
>

Looks good. Thanks!

> I added this fix to the r1470738 in ^/subversion/branches/1.8.x/STATUS.
> Can you review this addition?
>

Done.

-- Stefan^2.

-- 
*Join one of our free daily demo sessions on* *Scaling Subversion for the
Enterprise <http://www.wandisco.com/training/webinars>*
*
*