[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Missing newline in propset error message

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Mon, 15 Apr 2013 14:38:00 +0100

Mattias Engdegård <mattiase_at_bredband.net> writes:

> Here is a patch. (I didn't add a newline to the string directly since
> it occurs in many places.)

The explaination should go in the code not the email otherwise somebody
else may change the code. I don't understand the explaination, is this
to make translation easier?

> case svn_wc_notify_path_nonexistent:
> - err = svn_cmdline_printf(pool, _("'%s' is not under version control"),
> - path_local);
> + err = svn_cmdline_printf(pool, "%s\n",
> + apr_psprintf(pool, _("'%s' is not under version control"),
> + path_local));
> if (err)
> goto print_error;
> break;

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download
Received on 2013-04-15 15:38:35 CEST

This is an archived mail posted to the Subversion Dev mailing list.