[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Missing newline in propset error message

From: Mattias Engdegård <mattiase_at_bredband.net>
Date: Sun, 14 Apr 2013 16:19:43 +0200

There is a missing newline in the error when propset is used on a
nonexisting file:

$ svn ps a b file
'file' is not under version controlsvn: E155010: The node '/tmp/d1/
file' was not found.

Here is a patch. (I didn't add a newline to the string directly since
it occurs in many places.)

[[[
Add missing newline to the message when doing propset
on a nonexisting file.

* subversion/svn/notify.c
   (notify): Add missing newline, keeping the string itself
    intact to be nice to the translators.
]]]

Index: subversion/svn/notify.c
===================================================================
--- subversion/svn/notify.c (revision 1467712)
+++ subversion/svn/notify.c (working copy)
@@ -1050,8 +1050,9 @@
       break;
 
     case svn_wc_notify_path_nonexistent:
- err = svn_cmdline_printf(pool, _("'%s' is not under version control"),
- path_local);
+ err = svn_cmdline_printf(pool, "%s\n",
+ apr_psprintf(pool, _("'%s' is not under version control"),
+ path_local));
       if (err)
         goto print_error;
       break;

Received on 2013-04-14 16:20:20 CEST

This is an archived mail posted to the Subversion Dev mailing list.