Re: [PATCH] Avoid warning when char is unsigned

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Mon, 15 Apr 2013 13:45:24 +0100

Mattias EngdegÃ¥rd <mattiase_at_bredband.net> writes:

> Avoid a "condition always true" warning on platforms where char
> is unsigned by default, such as PowerPC and ARM.
>
> * subversion/libsvn_subr/utf_validate.c
> (first_non_fsm_start_char, first_non_fsm_start_char_cstring):
> Add explicit cast to avoid warning when plain char is unsigned.

Looks correct, +1

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download

Received on 2013-04-15 14:46:05 CEST

This message: [ Message body ]
Next message: Philip Martin: "Re: [PATCH] Missing newline in propset error message"
Previous message: Mario Brandt: "Re: Making the Windows Build Easier"
In reply to: Mattias Engdegård: "[PATCH] Avoid warning when char is unsigned"
Next in thread: Mattias Engdegård: "Re: [PATCH] Avoid warning when char is unsigned"
Reply: Mattias Engdegård: "Re: [PATCH] Avoid warning when char is unsigned"

Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]