[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Filenames with trailing newlines wreak havoc

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Sun, 14 Apr 2013 04:26:19 +0300

Johan Corveleyn wrote on Sun, Apr 14, 2013 at 01:14:58 +0200:
> On Tue, Apr 9, 2013 at 3:08 PM, Stefan Sperling <stsp_at_elego.de> wrote:
> > On Wed, Apr 03, 2013 at 01:04:43PM +0200, Stefan Sperling wrote:
> >> To refresh our collective memory, the current trunk code does:
> >> - prevent newlines from entering filenames at the fsfs layer
> >> - prevent control characters from entering filenames at the repos layer
> >
> > I have nominated backports of this behaviour to 1.7.x and 1.6.x.
> > Thanks everyone for the very productive discussion about this issue!
>
> Daniel said this on the users list [1], in relation to
> (syncing/dumping-loading) non-LF svn:log props:
>
> "The LF check happens in the repos layer, but 'svnadmin load' uses the FS
> API directly so it doesn't trip that check. svnsync can't do this ..."
>
> Which made me wonder about the implications of this new filename
> checking code in the repos layer and fsfs layer on 'svnsync' on the
> one hand, and on 'svnadmin load' on the other hand.
>

FSFS \n pathnames never worked and don't work, this is just a "Fail fast
due to a known implementation bug" case. The repos commit editor patch
is a different story....

Daniel

> The fact that the checks at both layers are different means that you
> can still 'svnadmin load' a repos with filenames with (non-LF) control
> characters, but you can't svnsync it anymore.
>
> Not sure if that's important. Just making an observation ...
>
> [1] http://svn.haxx.se/users/archive-2013-04/0106.shtml
>
> --
> Johan
Received on 2013-04-14 03:26:58 CEST

This is an archived mail posted to the Subversion Dev mailing list.