Re: svn commit: r1411671 - /subversion/trunk/subversion/libsvn_ra_serf/serf.c
From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Tue, 20 Nov 2012 14:53:05 +0000 (GMT)
> Author: cmpilato
Oops -- that logic was there to catch the fact that the default 3600 seconds goes negative in the 32-bit variable it's assigned to.
It's stupid and backwards for at least two reasons.
1) Bert says on IRC, "The timeout value in neon was used for a completely different purpose: In neon: complete request timeout, in serf: chunk received timeout. Default http timeout is 30 or 60 minutes.† A bit long for waiting for a tcp segment."
So I guess we should set the default to something more sane such as ... one minute?
2) Why store microseconds (I know it's APR's standard for time values) and allocate a 32-bit variable for it?††Either use a bigger variable or just store the number of whole seconds.
This is an archived mail posted to the Subversion Dev mailing list.