Re: svn commit: r1411671 - /subversion/trunk/subversion/libsvn_ra_serf/serf.c
From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Tue, 20 Nov 2012 11:39:19 -0500
On 11/20/2012 09:53 AM, Julian Foad wrote:
Ah! Shoot. Sorry about the broken tests.
> 1) Bert says on IRC, "The timeout value in neon was used for a completely different purpose: In neon: complete request timeout, in serf: chunk received timeout. Default http timeout is 30 or 60 minutes. A bit long for waiting for a tcp segment."
5 minutes -- the same as Apache httpd's default timeout for receiving data
> 2) Why store microseconds (I know it's APR's standard for time values) and allocate a 32-bit variable for it? Either use a bigger variable or just store the number of whole seconds.
Agreed. This is just silly.
-- C. Michael Pilato <cmpilato_at_collab.net> CollabNet <> www.collab.net <> Enterprise Cloud Development
This is an archived mail posted to the Subversion Dev mailing list.