[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add platform information to user agent string

From: Branko Čibej <brane_at_wandisco.com>
Date: Mon, 05 Nov 2012 16:51:35 +0100

On 05.11.2012 15:43, Ivan Zhakov wrote:
> On Mon, Nov 5, 2012 at 6:30 PM, Branko Čibej <brane_at_wandisco.com> wrote:
>> On 05.11.2012 15:10, Ivan Zhakov wrote:
>>> Here is updated patch:
>>> [[[
>>> Add target platform information to user agent string.
>>>
>>> * subversion/libsvn_ra_serf/ra_serf.h
>>> (USER_AGENT): Add target platform information.
>>> * subversion/libsvn_ra_serf/ra_svn.h
>>> (SVN_RA_SVN__DEFAULT_USERAGENT): Add target platform information.
>>> * configure.ac
>>> (SVN_BUILD_TARGET): Define to ${target}.
>>> * subversion/svn_private_config.hw
>>> (SVN_BUILD_TARGET): Define.
>>> ]]]
>>>
>>> NOTE: I tested it only on Windows platform.
>> The patch looks OK, but you'll also have to do something with
>>
>> build/transform_config_hw.py
>>
>> so that the SVN_BUILD_TARGET in svn_private_config.hw gets set to the
>> correct value.
>>
> We cannot add Windows version information to SVN_BUIILD_TARGET like we
> do for SVN_BUILD_HOST, since we compile it for any Windows version.

Well, in that case I suggest you do something like this:

in svn_private_config.hw, e.g.:

    #define SVN_BUILD_TARGET SVN__MSBUILD__BUILD_TARGET

then update the visual studio project file templates to define
SVN__MSBUILD__BUILD_TARGET based on the actual configuration that's
being compiled.

It'd look really silly if every Windows client had x64 in the user agent
string.

-- Brane
Received on 2012-11-05 16:52:12 CET

This is an archived mail posted to the Subversion Dev mailing list.