[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH] Add platform information to user agent string

From: Bert Huijben <bert_at_qqmail.nl>
Date: Mon, 5 Nov 2012 16:08:39 +0100

> -----Original Message-----
> From: Branko Čibej [mailto:brane_at_wandisco.com]
> Sent: maandag 5 november 2012 15:31
> To: dev_at_subversion.apache.org
> Subject: Re: [PATCH] Add platform information to user agent string
>
> On 05.11.2012 15:10, Ivan Zhakov wrote:
> > Here is updated patch:
> > [[[
> > Add target platform information to user agent string.
> >
> > * subversion/libsvn_ra_serf/ra_serf.h
> > (USER_AGENT): Add target platform information.
> > * subversion/libsvn_ra_serf/ra_svn.h
> > (SVN_RA_SVN__DEFAULT_USERAGENT): Add target platform
> information.
> > * configure.ac
> > (SVN_BUILD_TARGET): Define to ${target}.
> > * subversion/svn_private_config.hw
> > (SVN_BUILD_TARGET): Define.
> > ]]]
> >
> > NOTE: I tested it only on Windows platform.
>
> The patch looks OK, but you'll also have to do something with
>
> build/transform_config_hw.py
>
> so that the SVN_BUILD_TARGET in svn_private_config.hw gets set to the
> correct value.
>
> (We might want to use this macro in svn --version [--verbose], too; but
> that's a separate issue.)

Our Visual C++ project files allow building with both x64 and x86, while the same transform target file in trunk/Debug and/or trunk/Release is used for both of them.

        Bert
Received on 2012-11-05 16:09:58 CET

This is an archived mail posted to the Subversion Dev mailing list.