Re: [PATCH] Add platform information to user agent string

On Mon, Nov 5, 2012 at 6:30 PM, Branko Čibej <brane_at_wandisco.com> wrote:
> On 05.11.2012 15:10, Ivan Zhakov wrote:
>> Here is updated patch:
>> [[[
>> Add target platform information to user agent string.
>>
>> * subversion/libsvn_ra_serf/ra_serf.h
>> (USER_AGENT): Add target platform information.
>> * subversion/libsvn_ra_serf/ra_svn.h
>> (SVN_RA_SVN__DEFAULT_USERAGENT): Add target platform information.
>> * configure.ac
>> (SVN_BUILD_TARGET): Define to ${target}.
>> * subversion/svn_private_config.hw
>> (SVN_BUILD_TARGET): Define.
>> ]]]
>>
>> NOTE: I tested it only on Windows platform.
>
> The patch looks OK, but you'll also have to do something with
>
> build/transform_config_hw.py
>
> so that the SVN_BUILD_TARGET in svn_private_config.hw gets set to the
> correct value.
>
We cannot add Windows version information to SVN_BUIILD_TARGET like we
do for SVN_BUILD_HOST, since we compile it for any Windows version.

-- 
Ivan Zhakov