[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Implement svnadmin verify --force

From: Prabhu Gnana Sundar <prabhugs_at_collab.net>
Date: Wed, 31 Oct 2012 22:14:12 +0530

Thanks Daniel,

Attaching the patch that would fix the suggestions given by you.

Thanks and regards
Prabhu

On 10/31/2012 08:28 PM, Daniel Shahaf wrote:
>> Index: subversion/libsvn_repos/dump.c
>> ===================================================================
>> --- subversion/libsvn_repos/dump.c (revision 1402414)
>> +++ subversion/libsvn_repos/dump.c (working copy)
>> @@ -1359,10 +1359,23 @@
>> return close_directory(dir_baton, pool);
>> }
>>
>> +void *
> Should return void (not pointer thereto).
>
>> +notify_verification_error(svn_revnum_t rev, svn_error_t *err,
>> + svn_repos_notify_func_t notify_func,
>> + void *notify_baton, apr_pool_t *pool)
>> +{
>> + svn_repos_notify_t *notify_failure;
>> + notify_failure = svn_repos_notify_create(svn_repos_notify_failure, pool);
>> + notify_failure->err = err;
>> + notify_failure->revision = rev;
>> + notify_func(notify_baton, notify_failure, pool);
> You've again ignored my review comments - this time about not calling
> NOTIFY_FUNC when it's NULL and about documenting in the docstring the
> effect of (keep_going=TRUE, notify_func=NULL).
>
> Please don't make that a

Received on 2012-10-31 17:52:34 CET

This is an archived mail posted to the Subversion Dev mailing list.