[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1404159 - /subversion/trunk/subversion/libsvn_subr/named_atomic.c

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Wed, 31 Oct 2012 16:38:21 +0000 (GMT)

Philip Martin:

> stefan2_at_apache.org writes:
>> +      /* Sanitize (in case of data corruption)
>> +      */
>> +      if (new_ns->data->count > MAX_ATOMIC_COUNT)
>> +        new_ns->data->count = MAX_ATOMIC_COUNT;
>
> I'm still seeing a crash:
>
> 467          if (new_ns->data->count > MAX_ATOMIC_COUNT)
> (gdb) p new_ns->data->count
> $1 = -1382404098

Also, if the count is "corrupted", I want to ask: are we sure it is then safe to adjust the count and carry on?  (I haven't been paying close attention, I'm just asking.)

- Julian
Received on 2012-10-31 17:38:59 CET

This is an archived mail posted to the Subversion Dev mailing list.