[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Implement svnadmin verify --force

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Wed, 31 Oct 2012 16:58:25 +0200

> Index: subversion/libsvn_repos/dump.c
> ===================================================================
> --- subversion/libsvn_repos/dump.c (revision 1402414)
> +++ subversion/libsvn_repos/dump.c (working copy)
> @@ -1359,10 +1359,23 @@
> return close_directory(dir_baton, pool);
> }
>
> +void *

Should return void (not pointer thereto).

> +notify_verification_error(svn_revnum_t rev, svn_error_t *err,
> + svn_repos_notify_func_t notify_func,
> + void *notify_baton, apr_pool_t *pool)
> +{
> + svn_repos_notify_t *notify_failure;
> + notify_failure = svn_repos_notify_create(svn_repos_notify_failure, pool);
> + notify_failure->err = err;
> + notify_failure->revision = rev;
> + notify_func(notify_baton, notify_failure, pool);

You've again ignored my review comments - this time about not calling
NOTIFY_FUNC when it's NULL and about documenting in the docstring the
effect of (keep_going=TRUE, notify_func=NULL).

Please don't make that a habit.
Received on 2012-10-31 15:59:05 CET

This is an archived mail posted to the Subversion Dev mailing list.