[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Implement svnadmin verify --force

From: Prabhu Gnana Sundar <prabhugs_at_collab.net>
Date: Wed, 31 Oct 2012 16:42:39 +0530

Thanks Stefan,

Addressed the suggestions in this patch. Attaching the log message too
with this mail.
Please share your thoughts...

Thanks and regards
Prabhu

On 10/30/2012 08:38 PM, Stefan Sperling wrote:
> On Tue, Oct 30, 2012 at 04:07:49PM +0200, Daniel Shahaf wrote:
>> Prabhu Gnana Sundar wrote on Tue, Oct 30, 2012 at 19:22:31 +0530:
>>> + if (err&& keep_going)
>>> + {
>>> + svn_repos_notify_t *notify_failure;
>>> + notify_failure = svn_repos_notify_create(svn_repos_notify_failure,
>>> + iterpool);
>>> + notify_failure->err = err;
>>> + notify_func(notify_baton, notify_failure, iterpool);
>>> + svn_error_clear(err);
>>> + }
>>> + else
>>> + return svn_error_trace(err);
>> This pattern repeats three times, maybe introduce a macro (like SVN_ERR,
>> SVN_INT_ERR, etc) to improve readability?
> I'd prefer a new helper function instead of a new macro.
> Perhaps something like:
>
> if (err&& keep_going)
> notify_verification_error(err, rev, pool);
> else
> SVN_ERR(err);

Received on 2012-10-31 12:20:54 CET

This is an archived mail posted to the Subversion Dev mailing list.