[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Implement svnadmin verify --force

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Sun, 21 Oct 2012 17:47:28 +0200

Please address my earlier review question, asking why this needs to be
implemented in the library and can't be done satisfactorily in user
(C or Python) code.

Prabhu Gnana Sundar wrote on Sun, Oct 21, 2012 at 00:57:47 +0530:
> Thanks Stefan,
>
> I have written a new patch as per your suggestions and Julian's
> suggestions. Attaching the new patch and the log message with this mail.
> Please share your thoughts.

> Implement svnadmin verify --force, which would continue the verification
> even if there is some corruption, after printing the errors to stderr.
>
> * subversion/svnadmin/main.c
> (svnadmin__cmdline_options_t):
> (svnadmin_opt_state) : add keep-going option.
> (subcommand_verify) : uses the new svn_repos_verify_fs3 function.
> (repos_notify_handler) : handles failure and prints warning to stderr.
>
> * subversion/include/svn_repos.h
> (svn_repos_notify_action_t): add svn_repos_notify_failure to notify failure.
> (svn_repos_verify_fs3) : newly added to handle "keep-going" option.
>
> * subversion/libsvn_repos/dump.c
> (svn_repos_verify_fs3): now handles "keep-going".
> If "keep-going" is TRUE, then the error message is
> written to the stderr and verify process continues.
>
> * subversion/libsvn_repos/deprecated.c
> (svn_repos_verify_fs2) : deprecated.
> Now calls svn_repos_verify_fs3 with keep-going as FALSE.
>
>
> Patch by: Prabhu Gnana Sundar <prabhugs{_AT_}collab.net>
Received on 2012-10-21 17:48:06 CEST

This is an archived mail posted to the Subversion Dev mailing list.