Re: revprop packing question

Stefan Fuhrmann wrote on Sat, Oct 20, 2012 at 13:55:14 +0200:
> On Tue, Oct 16, 2012 at 2:30 AM, Daniel Shahaf <d.s_at_daniel.shahaf.name>wrote:
>
> > Daniel Shahaf wrote on Tue, Oct 16, 2012 at 02:24:12 +0200:
> > > libsvn_fs_fs/structure says that a pack file starts with an
> > > svndiff-encoded integer. Where is that integer written, please?
> > >
> >
> > I meant, "Where is the code that writes that integer".
> >
>
> It is being written & read / evaluated by svn__compress /
> svn__decompress. Those, in turn are being called by
> repack_revprops and parse_packed_revprops. So, technically,
> the revprop files are always compressed.
>

That's what I expected from reading the code; but reading 'structure'
had me think that the compressed integer is part of the plaintext (ie,
the input to __compress and output of __decompress).

IOW, I expected 'structure' to only say "it's compressed" without
details of the copmression function's file format.

> r1400133 adds a description of the binary integer format.
>
> -- Stefan^2.

Thanks, I'll read it.
Received on 2012-10-21 17:52:57 CEST