Re: [PATCH] Add support for http_proxy and https_proxy environment variables

On 13.09.2012 14:03, C. Michael Pilato wrote:
> - While your approach was the super simple one to take, how do we feel
> about the fact that this would cause all programs which linked against
> Subversion's libs to start noticing those environment variables which
> are really kind meant to be specific to just the command-line clients.
> In the past, I (and others) have gone on record against such things.
> Perhaps a better approach would be for 'svn' -- or one of the common
> svn_cmdline_* functions in libsvn_subr -- to parse the env variables
> and use the results to override the parsed runtime configuration
> values in the svn_config_t structures that get passed all over the
> place. I dunno.

I'd argue the other way, that in this case, the settings in the config
file should override those gleaned from the environment.

Agree on environment parsing being cmdline-specific.

-- Brane

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download