RE: [PATCH] Add support for http_proxy and https_proxy environment variables

> -----Original Message-----
> From: Branko Čibej [mailto:brane_at_wandisco.com]
> Sent: donderdag 13 september 2012 14:19
> To: dev_at_subversion.apache.org
> Subject: Re: [PATCH] Add support for http_proxy and https_proxy
> environment variables
>
> On 13.09.2012 14:03, C. Michael Pilato wrote:
> > - While your approach was the super simple one to take, how do we feel
> > about the fact that this would cause all programs which linked against
> > Subversion's libs to start noticing those environment variables which
> > are really kind meant to be specific to just the command-line clients.
> > In the past, I (and others) have gone on record against such things.
> > Perhaps a better approach would be for 'svn' -- or one of the common
> > svn_cmdline_* functions in libsvn_subr -- to parse the env variables
> > and use the results to override the parsed runtime configuration
> > values in the svn_config_t structures that get passed all over the
> > place. I dunno.
>
> I'd argue the other way, that in this case, the settings in the config
> file should override those gleaned from the environment.
>
> Agree on environment parsing being cmdline-specific.

+1 on making the parsing cmdline specific and at least not making this magic part of ra_dav_serf.

(There were earlier suggestions of using lib_proxy as an optional dependency to find proxy servers in a more generic way. Are these variables the unix way of finding the proxy?)

I don't think the suggested environment options are in common use on Windows, but I don't like adding yet another uncommon place where to configure Subversion settings for all clients.

TortoiseSVN and AnkhSVN both provide a UI to set the proxy in the common Subversion registry location, which (by using the common location) is also picked up by other Subversion clients.

        Bert
Received on 2012-09-13 15:19:58 CEST