On 09/13/2012 08:19 AM, Branko Čibej wrote:
> On 13.09.2012 14:03, C. Michael Pilato wrote:
>> - While your approach was the super simple one to take, how do we feel
>> about the fact that this would cause all programs which linked against
>> Subversion's libs to start noticing those environment variables which
>> are really kind meant to be specific to just the command-line clients.
>> In the past, I (and others) have gone on record against such things.
>> Perhaps a better approach would be for 'svn' -- or one of the common
>> svn_cmdline_* functions in libsvn_subr -- to parse the env variables
>> and use the results to override the parsed runtime configuration
>> values in the svn_config_t structures that get passed all over the
>> place. I dunno.
>
> I'd argue the other way, that in this case, the settings in the config
> file should override those gleaned from the environment.
Yeah, I don't really have an opinion about the prioritization here. What I
was primarily trying to get across was that modifying the svn_config_t would
be an easy way to get updated values passed throughout our libraries.
> Agree on environment parsing being cmdline-specific.
Cool.
--
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet <> www.collab.net <> Enterprise Cloud Development
Received on 2012-09-13 14:30:32 CEST