[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] issue #4134 (partial): sort deleted nodes before dumping them

From: Dustin Lang <dstn_at_astro.princeton.edu>
Date: Thu, 31 May 2012 14:31:01 -0400 (EDT)

The point of this diff is to ensure that "svnadmin dump" lists the deleted nodes
in a consistent order between runs. At this point in the code, we're just
dealing with a list of strings, so it really doesn't matter, we just need them
in a consistent ordering. lexically looks simpler and faster (not that this is
performance-critical).

How about this comment:

// We just need the paths to be emitted in a consistent order, so lexical sort
// is fine (ie, we don't need svn_sort_compare_paths, but it work work too).

cheers,
--dstn

On Thu, 31 May 2012, Julian Foad wrote:

> Stefan Sperling wrote:
>
>> On Wed, May 30, 2012 at 07:55:34AM +0100, Julian Foad wrote:
>>> If you're using _lexically on these paths, please explain this in a
>>> comment, otherwise this will be confusing to readers.
>>
>> Bert expanded the docstring of svn_sort_compare_items_lexically
>> in r1344158.
>
> No, he expanded docs of svn_path_compare_paths() and svn_sort_compare_items_as_paths().
>
>> I guess that addresses your concern?
>
> Not really; there's no direct links from this usage of _lexically() to Bert's comment, and I'm taking the fact that a to-and-fro email discussion occurred as evidence that it's not totally obvious.
>
>> If so, I'll apply Dustin's patch unmodified.
>
> I'm only offering my opinion; I won't be offended if you think it's clear enough and go ahead without adding a comment.
>
> - Julian
>
Received on 2012-05-31 20:31:37 CEST

This is an archived mail posted to the Subversion Dev mailing list.