Re: [PATCH] issue #4134 (partial): sort deleted nodes before dumping them

Stefan Sperling wrote:

> On Wed, May 30, 2012 at 07:55:34AM +0100, Julian Foad wrote:
>> If you're using _lexically on these paths, please explain this in a
>> comment, otherwise this will be confusing to readers.
>
> Bert expanded the docstring of svn_sort_compare_items_lexically
> in r1344158.

No, he expanded docs of svn_path_compare_paths() and svn_sort_compare_items_as_paths().

> I guess that addresses your concern?

Not really; there's no direct links from this usage of _lexically() to Bert's comment, and I'm taking the fact that a to-and-fro email discussion occurred as evidence that it's not totally obvious.

> If so, I'll apply Dustin's patch unmodified.

I'm only offering my opinion; I won't be offended if you think it's clear enough and go ahead without adding a comment.

- Julian
Received on 2012-05-31 20:12:44 CEST