[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] issue #4134 (partial): sort deleted nodes before dumping them

From: Stefan Sperling <stsp_at_elego.de>
Date: Thu, 31 May 2012 20:52:12 +0200

On Thu, May 31, 2012 at 02:31:01PM -0400, Dustin Lang wrote:
>
> The point of this diff is to ensure that "svnadmin dump" lists the
> deleted nodes in a consistent order between runs. At this point in
> the code, we're just dealing with a list of strings, so it really
> doesn't matter, we just need them in a consistent ordering.
> lexically looks simpler and faster (not that this is
> performance-critical).

I think we'd also like to get output that is similar to what happened
with ARP-1.4.5 (i.e. before the hash table randomness change in APR-1.4.6).
I believe that was equivalent to lexical sort. The entries are hash keys,
and the hash function in APR didn't result in the kind of ordering that
svn_sort_compare_paths would choose.
Received on 2012-05-31 20:52:56 CEST

This is an archived mail posted to the Subversion Dev mailing list.