[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Ruby bindings failing on buildbots

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Wed, 21 Mar 2012 10:33:16 +0000

Joe Swatosh <joe.swatosh_at_gmail.com> writes:

> Before r1293375, the node that represented 'diff1.txt' in this walk
> had the "prop_mod" member set true. After r1293375, the "prop_mod"
> member for this node is false. Since the implementation of
> Svn::Info#get_diff_recurse checks "prop_mod" member before attempting
> to collect the property changes on the node, the test started failing.

I don't understand why prop_mod is no longer being set.

> My second patch removes the (optimization?) check for the "prop_mod"
> member and thus always get the properties from the prior revision and
> compares them with the current version. Making the test pass again for
> me.

That also looks dubious to me.

> Is the prop_mod not being set in this scenario for this node the
> desired behavior?

In the past a property delete caused prop_mod to be set and now it does
not. The Subversion core is still reporting the property delete to the
Ruby bindings layer at ChangedEditor.change_file_prop. I don't
understand the Ruby code so I don't know why prop_mod is no longer set
but it seems like a bug to me.

-- 
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com
Received on 2012-03-21 11:33:55 CET

This is an archived mail posted to the Subversion Dev mailing list.