[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Revision 1297676 broke --list option of command line tests

From: Hyrum K Wright <hyrum.wright_at_wandisco.com>
Date: Tue, 6 Mar 2012 15:20:10 -0600

I think the solution here is to rip out places that require
options.verbose, rather than attempt to paper over the problem by
resurrecting that field. I've attempted to do so in subsequent
commits (see r1297724 and r1297725).

-Hyrum

On Tue, Mar 6, 2012 at 3:11 PM, Alexey Neyman <stilor_at_att.net> wrote:
> Argh, damn. Last one:
>
> [[[
> * subversion/tests/cmdline/svntest/main.py
>  (_create_parser): Partially revert r1297676, other code needs
>                    options.verbose.
>  (_parse_options): Call logger.setLevel(logging.DEBUG) if verbose
>                    output is requested.
> ]]]
>
> On Tuesday, March 06, 2012 12:50:30 pm Alexey Neyman wrote:
>> Please use the attached patch instead (the first one fixed "--list", but
>> not "--list --verbose").
>>
>> Regards,
>> Alexey.
>>
>> On Tuesday, March 06, 2012 12:45:21 pm Alexey Neyman wrote:
>> > Hi all,
>> >
>> > Revision 1297676 by hwright broke the command line tests' --list option
>> > (and probably, some other interfaces): the options dict no longer
>> > contains verbose option as --verbose handler was changed from
>> > 'store_true' to 'callback'. The attached patch fixes it by reintroducing
>> > options.verbose.
>> >
>> > [[[
>> > * subversion/tests/cmdline/svntest/main.py
>> >
>> >   (_create_parser): Set options.verbose to False by default, override
>> >   with
>> >
>> >                     True from set_log_debug() callback.
>> >
>> > ]]]
>> >
>> > Regards,
>> > Alexey.

-- 
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/
Received on 2012-03-06 22:20:43 CET

This is an archived mail posted to the Subversion Dev mailing list.