[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Revision 1297676 broke --list option of command line tests

From: Alexey Neyman <stilor_at_att.net>
Date: Tue, 6 Mar 2012 13:11:11 -0800

Argh, damn. Last one:

[[[
* subversion/tests/cmdline/svntest/main.py
  (_create_parser): Partially revert r1297676, other code needs
                    options.verbose.
  (_parse_options): Call logger.setLevel(logging.DEBUG) if verbose
                    output is requested.
]]]

On Tuesday, March 06, 2012 12:50:30 pm Alexey Neyman wrote:
> Please use the attached patch instead (the first one fixed "--list", but
> not "--list --verbose").
>
> Regards,
> Alexey.
>
> On Tuesday, March 06, 2012 12:45:21 pm Alexey Neyman wrote:
> > Hi all,
> >
> > Revision 1297676 by hwright broke the command line tests' --list option
> > (and probably, some other interfaces): the options dict no longer
> > contains verbose option as --verbose handler was changed from
> > 'store_true' to 'callback'. The attached patch fixes it by reintroducing
> > options.verbose.
> >
> > [[[
> > * subversion/tests/cmdline/svntest/main.py
> >
> > (_create_parser): Set options.verbose to False by default, override
> > with
> >
> > True from set_log_debug() callback.
> >
> > ]]]
> >
> > Regards,
> > Alexey.

Received on 2012-03-06 22:11:47 CET

This is an archived mail posted to the Subversion Dev mailing list.