On Mon, Dec 19, 2011 at 10:04:55AM +0200, Daniel Shahaf wrote:
> On Sun, Dec 18, 2011, at 18:37, Vincent Batts wrote:
> > I will start by working on all of the 'E' errors in the ruby tests
> > straight. I primarily want to see these ruby bindings back into the main
> > bundle of bindings, now that many distributions are defaulting to ruby
> > 1.9.x. Arch linux has followed upstream suite and shipped a subversion
> > without ruby bindings.
> >
> > Should I send a separate patch, or amend the previous?
>
> Please don't send interdiffs; but send patches against trunk_at_HEAD.
>
> Please send separate patches for separate functional changes. Getting
> the tests to pass with ruby1.8 would be a separate functional change than
> supporting ruby1.9.
The tests are passing for me locally with ruby 1.8.
I would suspect some local problem at Vincent's side is preventing them
from passing.
Received on 2011-12-19 11:47:28 CET