[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: 1.7.0 assert on svn_client_checkout with E235000

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Thu, 03 Nov 2011 07:48:16 -0400

On 11/02/2011 05:42 PM, Barry Scott wrote:
> I wish that the canonical stuff was inside the svn_client_XXX API calls and not
> a burdon on callers. To my mind the svn.exe API and the svn_client_XXX should
> accept the same strings and either operate or return an error. Avoiding the
> asserts from using svn_client_XXX is the lions share of the work of getting
> svn binding sane.

Two problems with such a move:

  - libsvn_client isn't the only API called from code outside of the
Subversion core distribution. What does to auto-canonicalization in
libsvn_client do if passing the same uncanonical path to libsvn_wc will then

  - canonicalizing inside the API means the API must therefore assume that
input paths are not canonical. That means performing the same
canonicalization over and over again each time the API is called. That's
wasteful. Better to ask the highest level of code to make its input conform
once (we even offer the functions to do so!) and then take advantage of
known-good input from then on.

C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2011-11-03 12:49:00 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.