Re: [PATCH] Don't repeatedly notify the same warning

On 08/28/2011 09:08 AM, Daniel Shahaf wrote:
> [[[
> Make 'svnadmin dump' print the following warning:
>
> WARNING 0x0001: Mergeinfo referencing revision(s) prior to the
> oldest dumped revision (4). Loading this dump may result in invalid
> mergeinfo.
>
> only once per dump operation, rather once per affected node. The
> repetition is deemed more noisy than useful. (There is already
> a warning at the end pointing the existence of warnings throughout
> the dump.)
>
> * subversion/libsvn_repos/dump.c:
> (TBD):
> Store the 'saw it' bit, not per-revision (in the edit baton) but per
> dump operation (in stack storage pointed to by the edit baton).
> (dump_node):
> Check the bit before generating the notification/warning.
> ]]]

Would it make more sense to just replace the warning at the end with a
single instance of each of the various mid-stream warnings? Or are all such
warnings not quite as redundant as this one?

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand