RE: Recurse into same-repos externals at commit time. (was: [PATCH] don't recursively-commit pegged file externals)
> -----Original Message-----
> From: C. Michael Pilato [mailto:cmpilato_at_collab.net]
> Sent: maandag 29 augustus 2011 17:40
> To: Neels J Hofmeyr
> Cc: Subversion Development
> Subject: Recurse into same-repos externals at commit time. (was: [PATCH]
> don't recursively-commit pegged file externals)
> On 08/29/2011 11:33 AM, C. Michael Pilato wrote:
> >> ### It is also debatable if we should also skip *un*pegged file externals
> >> from recursion, just like we do with dir externals.
> > I tend to lobby for treatment of file externals more consistently with
> > directory externals. But now that our commit crawler can handle multi-WC
> > commits, we could probably enable commit recursion into directory
> > which are pulled from the same repository as the primary one. (Maybe
> > has some thoughts about this?)
> See http://subversion.tigris.org/issues/show_bug.cgi?id=1167 (circa 2003).
> This would actually be a pretty cool to make happen for 1.8.
> What might the UI look like? Would we just skip (with a notification) any
> externals pulled from a foreign repository?
Personally, I don't think we should change the default behavior of not committing the externals with the parent.
I have no problem with adding an optional behavior, but I think the user should somehow choose to add them to the commit or it would surprise users and scripts that don't expect the current behavior to change.
(That is why I didn't add this part of the feature request)
Received on 2011-08-29 17:45:53 CEST
This is an archived mail posted to the Subversion Dev