[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1156375 - /subversion/branches/fs-py/subversion/python/svn/fs.py

From: Greg Stein <gstein_at_gmail.com>
Date: Wed, 10 Aug 2011 17:35:54 -0400

On Wed, Aug 10, 2011 at 17:26, <hwright_at_apache.org> wrote:
> Author: hwright
> Date: Wed Aug 10 21:26:36 2011
> New Revision: 1156375
> URL: http://svn.apache.org/viewvc?rev=1156375&view=rev
> Log:
> On the fs-py branch:
> Followup to r1156347: use a bit cleaner syntax to automagically close files.
> * subversion/python/svn/fs.py
> á(FS.set_uuid, FS._open_fs): Use the with statement.

And now where did your .close() call go? You're still relying on 'f'
going out of scope to close. IOW, right back to the zero refcount
algorithm. And in which case, the original construction is much
cleaner than all this "with" gunk.

Received on 2011-08-10 23:36:23 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.