[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1153416 - /subversion/trunk/subversion/libsvn_wc/status.c

From: Bert Huijben <bert_at_qqmail.nl>
Date: Wed, 3 Aug 2011 12:18:01 +0200

> -----Original Message-----
> From: Bert Huijben [mailto:bert_at_qqmail.nl]
> Sent: woensdag 3 augustus 2011 12:17
> To: Ivan Zhakov
> Cc: dev_at_subversion.apache.org
> Subject: RE: svn commit: r1153416 -
> /subversion/trunk/subversion/libsvn_wc/status.c
>
>
>
> > -----Original Message-----
> > From: ivan_at_apache.org [mailto:ivan_at_apache.org]
> > Sent: woensdag 3 augustus 2011 12:10
> > To: commits_at_subversion.apache.org
> > Subject: svn commit: r1153416 -
> > /subversion/trunk/subversion/libsvn_wc/status.c
> >
> > Author: ivan
> > Date: Wed Aug 3 10:10:22 2011
> > New Revision: 1153416
> >
> > URL: http://svn.apache.org/viewvc?rev=1153416&view=rev
> > Log:
> > Fix access to uninitialized variable.
> >
> > * subversion/libsvn_wc/status.c
> > (internal_status): Do not access NODE_STATUS if read_info() function
> > returned error.
> >
> > Modified:
> > subversion/trunk/subversion/libsvn_wc/status.c
> >
> > Modified: subversion/trunk/subversion/libsvn_wc/status.c
> > URL:
> >
> http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_wc/stat
> > us.c?rev=1153416&r1=1153415&r2=1153416&view=diff
> >
> ==========================================================
> > ====================
> > --- subversion/trunk/subversion/libsvn_wc/status.c (original)
> > +++ subversion/trunk/subversion/libsvn_wc/status.c Wed Aug 3 10:10:22
> > 2011
> > @@ -2464,21 +2464,24 @@ internal_status(svn_wc_status3_t **statu
> > db, local_abspath,
> > scratch_pool, scratch_pool);
> >
> > - if ((err && err->apr_err == SVN_ERR_WC_PATH_NOT_FOUND)
> > - || node_status == svn_wc__db_status_not_present
> > - || node_status == svn_wc__db_status_server_excluded
> > - || node_status == svn_wc__db_status_excluded)
> > + if (err && err->apr_err == SVN_ERR_WC_PATH_NOT_FOUND)
>
> Did you get an error from this if somehow?
> (Or via a analysis tool)

Forget this mail, or actually the previous one. I didn't look further then the if (err ||)

Sorry.

        Bert
 
Received on 2011-08-03 12:18:41 CEST

This is an archived mail posted to the Subversion Dev mailing list.