Re: svn commit: r1152410 - in /subversion/trunk/subversion/libsvn_wc: wc-queries.sql wc_db.c

On Mon, Aug 01, 2011 at 06:56:13PM +0200, Neels J Hofmeyr wrote:
> On 08/01/2011 04:17 PM, Stefan Sperling wrote:
> >> And at the same time this update of op_depth==0 rows during revert was not
> >> necessary before this patch.
> >
> > It wasn't necessary because it was cleared by the existing revert code.
>
> We had to add to the recursive revert code AFAIR

We added code to recursive revert when we started storing moved-to
in op_depth=0. Before then moved-to was in op_depth > 0 and cleared
out as part of existing operation of the revert code.

> So pretty much my only concern is: do we want to avoid modifying the
> op_depth==0 nodes?

The benefits of storing moved-to at op_depth 0 should now be quite
clear. But what's the benefit of not modifying op_depth = 0?
Note that op_depth=0 is always modified during commit and update.
It isn't read-only as such.
Received on 2011-08-01 19:11:16 CEST