Re: [PATCH] Fix for issue 3813

Daniel Shahaf <d.s_at_daniel.shahaf.name> writes:

> Looks like Bert committed a functionally equivalent fix as part of r1138474.
>

Bert,

May I know why this patch was not considered? Looking at the commit I
could not see any difference.

Thanks and Regards
Noorul

> Noorul Islam K M wrote on Wed, Jun 22, 2011 at 16:40:50 +0530:
>> +++ subversion/libsvn_wc/diff_editor.c (working copy)
>> @@ -1532,13 +1531,8 @@
>>
>>
>>
>> - /* This is the file that will contain the pristine repository version. It
>> - is created in the admin temporary area. This file continues to exists
>> - until after the diff callback is run, at which point it is deleted. */
>> - SVN_ERR(svn_wc__db_temp_wcroot_tempdir(&temp_dir, eb->db, fb->local_abspath,
>> - pool, pool));
>> SVN_ERR(svn_stream_open_unique(&temp_stream, &fb->temp_file_path,
>> - temp_dir, svn_io_file_del_on_pool_cleanup,
>> + NULL, svn_io_file_del_on_pool_cleanup,
>> fb->pool, fb->pool));
>>
>> whb = apr_pcalloc(fb->pool, sizeof(*whb));
Received on 2011-06-23 05:46:54 CEST