[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH] Fix for issue 3813

From: Bert Huijben <bert_at_qqmail.nl>
Date: Thu, 23 Jun 2011 11:30:20 +0200

> -----Original Message-----
> From: Noorul Islam K M [mailto:noorul_at_collab.net]
> Sent: donderdag 23 juni 2011 5:44
> To: Daniel Shahaf
> Cc: Julian Foad; Subversion; Bert Huijben
> Subject: Re: [PATCH] Fix for issue 3813
> Daniel Shahaf <d.s_at_daniel.shahaf.name> writes:
> > Looks like Bert committed a functionally equivalent fix as part of
> >
> Bert,
> May I know why this patch was not considered? Looking at the commit I
> could not see any difference.

Applying a one line patch takes me 5 times more time than just editing the
code. And as the final whitespace (and comment) didn't match your original
patch, adding a patch by wasn't really appropriate.

Discussion on irc showed that we couldn't just apply the patch without the
additional work from Stefan as that would open a window where somebody could
look at otherwise hidden files. (I assumed he would apply your patch after
that, but later I just applied the change anyway)

I just added a 'found by' to the log message of r1138474.

Received on 2011-06-23 11:30:52 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.