[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: API review - svn_dirent_uri.h

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Wed, 15 Jun 2011 12:52:37 -0400

On 06/15/2011 12:42 PM, Greg Stein wrote:
> On Wed, Jun 15, 2011 at 12:32, Julian Foad <julian.foad_at_wandisco.com> wrote:
>> Many callers of svn_dirent_skip_ancestor(), on the other hand, expect
>> the 'child' input to be returned if it is not in fact a child. I am
>> splitting the function into two:
>> svn_dirent_skip_ancestor() - return NULL if not a child
>> [some other function name] - return 'child' input if not a child
> PLEASE not another function.

Indeed. Can these many callers not just do:

   result = svn_dirent_skip_ancestor(parent, child) || child;


C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2011-06-15 18:53:12 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.